jihoonson commented on code in PR #12437:
URL: https://github.com/apache/druid/pull/12437#discussion_r851544444
##########
owasp-dependency-check-suppressions.xml:
##########
@@ -287,20 +287,6 @@
<packageUrl regex="true">^pkg:maven/log4j/[email protected]$</packageUrl>
<cve>CVE-2019-17571</cve>
</suppress>
- <suppress>
- <!--
- - TODO: The lastest version of ambari-metrics-common is 2.7.0.0.0,
released in July 2018.
- -->
- <notes><![CDATA[
- file name: ambari-metrics-common-2.7.0.0.0.jar (shaded:
io.netty:netty:3.10.5.Final)
- ]]></notes>
- <packageUrl
regex="true">^pkg:maven/io\.netty/[email protected]$</packageUrl>
- <cve>CVE-2019-16869</cve>
- <cve>CVE-2019-20444</cve>
- <cve>CVE-2019-20445</cve>
- <cve>CVE-2021-37136</cve>
- <cve>CVE-2021-37137</cve>
- </suppress>
Review Comment:
> This PR also cleans up a stale suppression for netty-3.10.5.Final which we
no longer use.
This part removed is what I mentioned in the PR description.
> When I ran the dependency check job on top of this PR I still got some
failures
What was the failure you saw? I guess it was the jackson-bind that should be
fixed in https://github.com/apache/druid/pull/12411?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
