loquisgon opened a new pull request, #12443:
URL: https://github.com/apache/druid/pull/12443
We have seen rare instances on the wild where during hash partitions the
determine cardinality phase produces a single shard with a large segment
without regards to the value of `macRowsPerSegment`. Attempts to reproduce
have not been successful so adding some defensive programming and logging in
case this happens again would be helpful. This PR deals with the improbable
case where the estimate from a `Union` `HLLSketch` that is used in the code
returns negative. It also adds some logging to report the values used to come
up with the final determination.
This PR has:
- [X ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [X ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ X] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [X ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
