kfaraz commented on code in PR #12368: URL: https://github.com/apache/druid/pull/12368#discussion_r855737263
########## docker-tests/it-batch-index/cluster.sh: ########## @@ -0,0 +1,63 @@ +#! /bin/bash + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +#-------------------------------------------------------------------- + +# Starts the test-specific test cluster using Docker compose using +# versions and other settings gathered when building the images. + +SCRIPT_DIR=$(cd $(dirname $0) && pwd) Review Comment: > Copy the `cluster.sh` script from an existing test. Add lines to copy any test-specific files into the `target/shared` folder. I see this mentioned in `docs/conversion.md` as something that might prevent this. Just guessing here, but couldn't that be done in some other way, say by putting them in `src/test/resources/shared`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
