LakshSingla commented on PR #12431: URL: https://github.com/apache/druid/pull/12431#issuecomment-1108066132
Both approaches seem to have some limitations, and using both simultaneously doesn't feel correct. IIUC with `RelNodes` based approach, the only drawback is the distinction between `EXPR$Digit` alias as entered by the user v/s one that gets generated automatically. Rejecting a column solely on the basis of EXPR$Digit (if entered) by the user doesn't seem correct. One hack I can think of is for all `EXPR$Digit` expressions, you can search the occurrence in the original SQL String and if it occurs, it probably was intentional. But we should get some validation from someone else before going down this route. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
