suneet-s commented on code in PR #12439:
URL: https://github.com/apache/druid/pull/12439#discussion_r857874447
##########
processing/src/main/java/org/apache/druid/query/aggregation/last/FloatLastVectorAggregator.java:
##########
@@ -47,9 +47,9 @@ void putValue(ByteBuffer buf, int position, int index)
}
@Override
- void initValue(ByteBuffer buf, int position)
+ public void initValue(ByteBuffer buf, int position)
{
- buf.putFloat(position, 0);
+ buf.putFloat(position, Float.NEGATIVE_INFINITY);
Review Comment:
hmm shouldn't this be 0? `FloatLastAggregator` initializes to 0
```suggestion
buf.putFloat(position, 0);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
