AmatyaAvadhanula commented on code in PR #12404:
URL: https://github.com/apache/druid/pull/12404#discussion_r860713854
##########
extensions-contrib/sqlserver-metadata-storage/src/test/java/org/apache/druid/metadata/storage/sqlserver/SQLServerConnectorTest.java:
##########
@@ -64,4 +64,27 @@ public void testIsTransientException()
Assert.assertFalse(connector.isTransientException(new Throwable("Throwable
with reason only")));
}
+ @Test
+ public void testLimitClause()
+ {
+ SQLServerConnector connector = new SQLServerConnector(
+ Suppliers.ofInstance(new MetadataStorageConnectorConfig()),
+ Suppliers.ofInstance(
+ new MetadataStorageTablesConfig(
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null
+ )
Review Comment:
done
##########
extensions-core/postgresql-metadata-storage/src/test/java/org/apache/druid/metadata/storage/postgresql/PostgreSQLConnectorTest.java:
##########
@@ -62,4 +62,30 @@ public void testIsTransientException()
Assert.assertFalse(connector.isTransientException(new Exception("I'm not
happy")));
Assert.assertFalse(connector.isTransientException(new Throwable("I give
up")));
}
+
+ @Test
+ public void testLimitClause()
+ {
+ PostgreSQLConnector connector = new PostgreSQLConnector(
+ Suppliers.ofInstance(new MetadataStorageConnectorConfig()),
+ Suppliers.ofInstance(
+ new MetadataStorageTablesConfig(
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null
+ )
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
