ektravel commented on code in PR #12416: URL: https://github.com/apache/druid/pull/12416#discussion_r861014300
########## docs/design/coordinator.md: ########## @@ -130,22 +129,22 @@ Assuming that each segment is 10 MB and haven't been compacted yet, this policy `foo_2017-11-01T00:00:00.000Z_2017-12-01T00:00:00.000Z_VERSION` and `foo_2017-11-01T00:00:00.000Z_2017-12-01T00:00:00.000Z_VERSION_1` to compact together because `2017-11-01T00:00:00.000Z/2017-12-01T00:00:00.000Z` is the most recent time chunk. -If the coordinator has enough task slots for compaction, this policy will continue searching for the next segments and return +If the Coordinator has enough task slots for compaction, this policy will continue searching for the next segments and return `bar_2017-10-01T00:00:00.000Z_2017-11-01T00:00:00.000Z_VERSION` and `bar_2017-10-01T00:00:00.000Z_2017-11-01T00:00:00.000Z_VERSION_1`. Finally, `foo_2017-09-01T00:00:00.000Z_2017-10-01T00:00:00.000Z_VERSION` will be picked up even though there is only one segment in the time chunk of `2017-09-01T00:00:00.000Z/2017-10-01T00:00:00.000Z`. -The search start point can be changed by setting [skipOffsetFromLatest](../configuration/index.md#compaction-dynamic-configuration). +The search start point can be changed by setting [`skipOffsetFromLatest`](../configuration/index.md#automatic-compaction-dynamic-configuration). If this is set, this policy will ignore the segments falling into the time chunk of (the end time of the most recent segment - `skipOffsetFromLatest`). This is to avoid conflicts between compaction tasks and realtime tasks. Note that realtime tasks have a higher priority than compaction tasks by default. Realtime tasks will revoke the locks of compaction tasks if their intervals overlap, resulting in the termination of the compaction task. > This policy currently cannot handle the situation when there are a lot of > small segments which have the same interval, -> and their total size exceeds [inputSegmentSizeBytes](../configuration/index.md#compaction-dynamic-configuration). +> and their total size exceeds [`inputSegmentSizeBytes`](../configuration/index.md#automatic-compaction-dynamic-configuration). > If it finds such segments, it simply skips them. ### The Coordinator console -The Druid Coordinator exposes a web GUI for displaying cluster information and rule configuration. For more details, please see [coordinator console](../operations/management-uis.md#coordinator-consoles). +The Druid Coordinator exposes a web GUI for displaying cluster information and rule configuration. For more details, please see [Coordinator console](../operations/management-uis.md#coordinator-consoles). Review Comment: ```suggestion The Druid Coordinator exposes a web GUI for displaying cluster information and rule configuration. For more details, see [Coordinator console](../operations/management-uis.md#coordinator-consoles). ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
