suneet-s commented on code in PR #12493:
URL: https://github.com/apache/druid/pull/12493#discussion_r862951087
##########
processing/src/main/java/org/apache/druid/query/aggregation/first/StringFirstLastUtils.java:
##########
@@ -59,6 +61,46 @@ public static boolean selectorNeedsFoldCheck(
|| SerializablePairLongString.class.isAssignableFrom(clazz);
}
+ /**
+ * Returns whether an object *might* contain SerializablePairLongString
objects.
+ */
+ public static boolean objectNeedsFoldCheck(Object obj)
+ {
+ if (obj == null) {
+ return false;
+ }
+ final Class<?> clazz = obj.getClass();
+ return clazz.isAssignableFrom(SerializablePairLongString.class)
+ || SerializablePairLongString.class.isAssignableFrom(clazz);
+ }
+
+ /**
+ * Return the object at a particular index from the vector selectors
+ */
Review Comment:
Important comment for this javadoc - index of bounds issues is the
responsibility of the caller
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
