vogievetsky commented on code in PR #12486:
URL: https://github.com/apache/druid/pull/12486#discussion_r863492827
##########
server/pom.xml:
##########
@@ -49,12 +49,6 @@
<version>${project.parent.version}</version>
<scope>runtime</scope>
</dependency>
- <dependency>
- <groupId>org.apache.druid</groupId>
- <artifactId>druid-console</artifactId>
- <version>${project.parent.version}</version>
- <scope>runtime</scope>
- </dependency>
Review Comment:
Heads up: I am reverting this change here
https://github.com/apache/druid/pull/12489/commits/592ddd4ef05617968cd4c3a9be846933455db67b
Removing the druid-console dependency makes the web console no longer be
part of Druid...
The e2e tests do not run unless there are JS changes which is how this PR
passed CI. I was struggling to figure out why my console PR
(https://github.com/apache/druid/pull/12489) was failing to even start the e2e
tests when it turned out that the console was just gone...
<img width="507" alt="image"
src="https://user-images.githubusercontent.com/177816/166409381-a40b310d-0c80-478b-8628-6691ac5f69d3.png";>
So I am adding this dependency back. Fun fact, my PR (linked above) will
actually improve the console build speed a little bit by removing the `stylus`
dependency but obviously not as much as not building the console all together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/177816/166409381-a40b310d-0c80-478b-8628-6691ac5f69d3.png"](https://user-images.githubusercontent.com/177816/166409381-a40b310d-0c80-478b-8628-6691ac5f69d3.png"){kind=link}