gianm commented on PR #12339: URL: https://github.com/apache/druid/pull/12339#issuecomment-1119142706
The new logic in this patch makes sense to me, but so does the old logic. I have a hard time understanding what was wrong with the old code. I don't see anything that would pick up `AWS_ROLE_ARN` either in the Druid codebase or in the AWS SDK codebase (it's only used in WebIdentityTokenCredentialsProvider; see https://github.com/aws/aws-sdk-java/search?q=AWS_ROLE_ARN_ENV_VAR). So if you don't specify `assumeRoleArn`, then it should be null, and so `applyAssumeRole` should do nothing. I figure what's going on must be related somehow to deserialization of the `properties` in your `inputSource`. Are you using an `s3` one and do you have a `properties` set in there? If so what properties are you setting? & how did you determine that `assumeRoleArn` was being set on the config object and that `applyAssumeRole` was doing things? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
