paul-rogers commented on code in PR #12368:
URL: https://github.com/apache/druid/pull/12368#discussion_r867230855


##########
pom.xml:
##########
@@ -1177,6 +1190,13 @@
                         <exclude>org/apache/druid/benchmark/**/*</exclude>  
<!-- benchmarks -->
                         <exclude>org/apache/druid/**/*Benchmark*</exclude>  
<!-- benchmarks -->
                         <exclude>org/apache/druid/testing/**/*</exclude>  <!-- 
integration-tests -->
+                        <!-- Would be better to put these IT items in a 
distinct package rather than
+                             reusing generic packages. Else exclusion is 
tedious. -->
+                        
<exclude>org/apache/druid/server/coordination/ServerManagerForQueryErrorTest.class</exclude>
+                        
<exclude>org/apache/druid/guice/SleepModule.class</exclude>
+                        
<exclude>org/apache/druid/guice/CustomNodeRoleClientModule.class</exclude>
+                        
<exclude>org/apache/druid/cli/CustomNodeRoleCommandCreator.class</exclude>
+                        
<exclude>org/apache/druid/cli/QueryRetryTestCommandCreator.class</exclude>

Review Comment:
   These are now for the "old" versions. Added a comment to clarify.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to