gianm commented on code in PR #12006:
URL: https://github.com/apache/druid/pull/12006#discussion_r877396896
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/RemoteTaskRunner.java:
##########
@@ -652,37 +652,50 @@ public Optional<ByteSource> streamTaskReports(final
String taskId)
if (zkWorker == null) {
// Worker is not running this task, it might be available in deep storage
return Optional.absent();
- } else {
- TaskLocation taskLocation = runningTasks.get(taskId).getLocation();
- final URL url = TaskRunnerUtils.makeTaskLocationURL(
- taskLocation,
- "/druid/worker/v1/chat/%s/liveReports",
- taskId
- );
- return Optional.of(
- new ByteSource()
+ }
+
+ final RemoteTaskRunnerWorkItem runningWorkItem = runningTasks.get(taskId);
+
+ if (runningWorkItem == null) {
+ // Worker very recently exited.
+ return Optional.absent();
+ }
+
+ final TaskLocation taskLocation = runningWorkItem.getLocation();
+
+ if (TaskLocation.unknown().equals(taskLocation)) {
+ // No location known for this task. It may have not been assigned one
yet.
Review Comment:
RUNNING means it's been assigned to a worker, known location means the
worker actually picked it up and launched it. There's a short but nonzero
amount of time between these two things happening.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
