loquisgon commented on code in PR #11550:
URL: https://github.com/apache/druid/pull/11550#discussion_r877401009
##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java:
##########
@@ -313,7 +316,10 @@ public Enumerable<Object[]> scan(DataContext root)
(long) segment.getShardSpec().getPartitionNum(),
numReplicas,
numRows,
- IS_PUBLISHED_TRUE, //is_published is true for published
segments
+ //is_active is true for published segments that are not
overshadowed
+ val.isOvershadowed() ? IS_ACTIVE_FALSE : IS_ACTIVE_TRUE,
Review Comment:
mmm.. isn't it a requirement for being active that is_overshadow and
is_publish both be true? Oh...got it. We already know that it is published if
we are here. So it is fine...never mind.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
