gianm commented on code in PR #12517:
URL: https://github.com/apache/druid/pull/12517#discussion_r877541918
##########
processing/src/main/java/org/apache/druid/segment/column/LexicographicalRangeIndex.java:
##########
@@ -39,18 +39,18 @@ default BitmapColumnIndex forRange(
boolean endStrict
)
{
- return forRange(startValue, startStrict, endValue, endStrict, (index) ->
true);
+ return forRange(startValue, startStrict, endValue, endStrict, null);
}
/**
* Get an {@link BitmapColumnIndex} corresponding to the values supplied in
the specified range whose dictionary ids
- * also match some predicate, such as to match a prefix
+ * also match some predicate, such as to match a prefix. Null matchers are
equivalent to always-true.
*/
BitmapColumnIndex forRange(
@Nullable String startValue,
boolean startStrict,
@Nullable String endValue,
boolean endStrict,
- Predicate<String> matcher
+ @Nullable Predicate<String> matcher
Review Comment:
> What do you think about instead of making this @Nullable to remove the
default implementation of the version of forRange which does not take a
predicate matcher?
☝️ I did this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
