This is an automated email from the ASF dual-hosted git repository.

abhishek pushed a commit to branch 0.23.0
in repository https://gitbox.apache.org/repos/asf/druid.git


The following commit(s) were added to refs/heads/0.23.0 by this push:
     new f0bba56dd6 Updates default inputSegmentSizeBytes in Compaction config 
(#12534) (#12548)
f0bba56dd6 is described below

commit f0bba56dd61bd66584c092403effc24e0e88f2bc
Author: Tejaswini Bandlamudi <[email protected]>
AuthorDate: Fri May 20 14:42:50 2022 +0530

    Updates default inputSegmentSizeBytes in Compaction config (#12534) (#12548)
    
    Fixes Cannot serialize BigInt value as JSON error while loading compaction 
config in console.
---
 .../apache/druid/server/coordinator/DataSourceCompactionConfig.java   | 3 ++-
 .../druid/server/coordinator/DataSourceCompactionConfigTest.java      | 4 ++--
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git 
a/server/src/main/java/org/apache/druid/server/coordinator/DataSourceCompactionConfig.java
 
b/server/src/main/java/org/apache/druid/server/coordinator/DataSourceCompactionConfig.java
index b786554feb..da89040f50 100644
--- 
a/server/src/main/java/org/apache/druid/server/coordinator/DataSourceCompactionConfig.java
+++ 
b/server/src/main/java/org/apache/druid/server/coordinator/DataSourceCompactionConfig.java
@@ -34,7 +34,8 @@ public class DataSourceCompactionConfig
 {
   /** Must be synced with Tasks.DEFAULT_MERGE_TASK_PRIORITY */
   public static final int DEFAULT_COMPACTION_TASK_PRIORITY = 25;
-  private static final long DEFAULT_INPUT_SEGMENT_SIZE_BYTES = Long.MAX_VALUE;
+  // Approx. 100TB. Chosen instead of Long.MAX_VALUE to avoid overflow on 
web-console and other clients
+  private static final long DEFAULT_INPUT_SEGMENT_SIZE_BYTES = 
100_000_000_000_000L;
   private static final Period DEFAULT_SKIP_OFFSET_FROM_LATEST = new 
Period("P1D");
 
   private final String dataSource;
diff --git 
a/server/src/test/java/org/apache/druid/server/coordinator/DataSourceCompactionConfigTest.java
 
b/server/src/test/java/org/apache/druid/server/coordinator/DataSourceCompactionConfigTest.java
index 6725dd3428..81b3311cdd 100644
--- 
a/server/src/test/java/org/apache/druid/server/coordinator/DataSourceCompactionConfigTest.java
+++ 
b/server/src/test/java/org/apache/druid/server/coordinator/DataSourceCompactionConfigTest.java
@@ -61,7 +61,7 @@ public class DataSourceCompactionConfigTest extends 
InitializedNullHandlingTest
     final DataSourceCompactionConfig config = new DataSourceCompactionConfig(
         "dataSource",
         null,
-        500L,
+        null,
         null,
         new Period(3600),
         null,
@@ -77,7 +77,7 @@ public class DataSourceCompactionConfigTest extends 
InitializedNullHandlingTest
 
     Assert.assertEquals(config.getDataSource(), fromJson.getDataSource());
     Assert.assertEquals(25, fromJson.getTaskPriority());
-    Assert.assertEquals(config.getInputSegmentSizeBytes(), 
fromJson.getInputSegmentSizeBytes());
+    Assert.assertEquals(100_000_000_000_000L, 
fromJson.getInputSegmentSizeBytes());
     Assert.assertEquals(config.getMaxRowsPerSegment(), 
fromJson.getMaxRowsPerSegment());
     Assert.assertEquals(config.getSkipOffsetFromLatest(), 
fromJson.getSkipOffsetFromLatest());
     Assert.assertEquals(config.getTuningConfig(), fromJson.getTuningConfig());


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to