superivaj commented on PR #12551: URL: https://github.com/apache/druid/pull/12551#issuecomment-1133095351
Hi @kfaraz, that you for your feedback. Looking forward to complete my first contribution! I have updated all the Unit Tests and Integration Tests that were failing because the constructors of `ClientCompactionTaskQueryTuningConfig` and `UserCompactionTaskQueryTuningConfig` now require an additional parameter (`maxColumnsToMerge`). Some of these tests evaluate the serialization/deserialization of these Config objects, which is where this objects were lacking this property. I can't think of anything else to add to the tests related to this change. Regarding my testing of this change, we are preparing a Druid cluster deployment and we tried to use `maxColumnsToMerge` to lower the memory consumption of the MiddleManagers during compaction. After this proposed change is applied, we can see the following differences: - Memory consumption is lower as expected - The "compaction configuration" of a DataSource as viewed through the web UI now includes the `maxColumnsToMerge` that before was missing (the JSON view only, not the FORM). - The coordinator logs confirm that the setting has been applied during the compaction. Please let me know if I need to complete any other step. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
