adarshsanjeev commented on code in PR #12558:
URL: https://github.com/apache/druid/pull/12558#discussion_r879037275
##########
sql/src/main/codegen/includes/insert.ftl:
##########
@@ -36,6 +36,11 @@ SqlNode DruidSqlInsertEof() :
<CLUSTERED> <BY>
clusteredBy = ClusterItems()
]
+ {
+ if (clusteredBy != null && partitionedBy.lhs == null) {
+ throw new ParseException("CLUSTERED BY clause found before PARTITIONED
BY, the PARITITIONED BY clause has to be specified first before the CLUSTERED
BY clause.");
+ }
+ }
Review Comment:
Partitioned by is nullable in the insert and replace classes, we can make
that a non null to make it cleaner if we move the null check here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
