clintropolis commented on code in PR #12542:
URL: https://github.com/apache/druid/pull/12542#discussion_r882459179
##########
processing/src/main/java/org/apache/druid/query/expression/IPv4AddressMatchExprMacro.java:
##########
@@ -106,13 +106,13 @@ public ExprEval eval(final ObjectBinding bindings)
private boolean isStringMatch(String stringValue)
{
IPv4Address iPv4Address = IPv4AddressExprUtils.parse(stringValue);
- return iPv4Address != null &&
subnetString.contains(iPv4Address.toAddressString());
+ return iPv4Address != null &&
subnetString.prefixContains(iPv4Address.toAddressString());
Review Comment:
1: I think yes, but looking closer I redid some things in the latest commit.
2: oops, missed the benchmark, which is what prompted me to look a bit closer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
