kfaraz commented on code in PR #12567: URL: https://github.com/apache/druid/pull/12567#discussion_r883254258
########## docs/querying/multitenancy.md: ########## @@ -75,10 +75,7 @@ stored on this tier. ## Supporting high query concurrency -Druid's fundamental unit of computation is a [segment](../design/segments.md). Processes scan segments in parallel and a -given process can scan `druid.processing.numThreads` concurrently. To -process more data in parallel and increase performance, more cores can be added to a cluster. Druid segments -should be sized such that any computation over any given segment should complete in at most 500ms. +Druid's fundamental unit of computation is a [segment](../design/segments.md). Processes scan segments in parallel and a given process can scan `druid.processing.numThreads` concurrently. To process more data in parallel and increase performance, more cores can be added to a cluster. Druid segments should be sized such that any computation over any given segment should complete in at most 500ms. The metric you need to check for this is [`query/segment/time`](../operations/metrics.md#historical). Review Comment: Nit: are we using the possessive case with `Druid` elsewhere, @techdocsmith ? Maybe we could fix this up too. e.g. `In Druid, the fundamental unit of computation is a segment` or `Druid uses a segment as the fundamental unit of computation` or something to that effect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
