gianm commented on PR #12388: URL: https://github.com/apache/druid/pull/12388#issuecomment-1140387984
The changes to NullColumnPartSerde in this patch introduce a compatibility problem: prior to this patch, `bitmapSerdeFactory` was a required parameter, and now it's gone. So that means segments with explicit null columns written by servers on this patch cannot be read by a server that has #12279. I noticed this when upgrading a dev cluster. We haven't done a release with #12279 yet, but it's slated to be in 0.23.0. So we should either change the code in 0.23.0 to not require `bitmapSerdeFactory`, or we should change master to write it out once again, lest we create an accidental storage format incompatibility. Any thoughts @clintropolis, @jihoonson, @abhishekagarwal87, or @imply-cheddar? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
