gianm commented on code in PR #12577:
URL: https://github.com/apache/druid/pull/12577#discussion_r885903791
##########
processing/src/main/java/org/apache/druid/segment/virtual/RowBasedExpressionColumnValueSelector.java:
##########
@@ -60,10 +68,16 @@ public RowBasedExpressionColumnValueSelector(
}
@Override
- public ExprEval getObject()
+ protected ExprEval<?> eval()
{
// check to find any arrays for this row
- List<String> arrayBindings =
unknownColumns.stream().filter(this::isBindingArray).collect(Collectors.toList());
Review Comment:
FYI, the de-streaming here is because I noticed the stream pipeline adding
extra CPU time and allocations in profiling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
