clintropolis commented on code in PR #12622: URL: https://github.com/apache/druid/pull/12622#discussion_r893288541
########## distribution/asf-release-process-guide.md: ########## @@ -71,6 +71,17 @@ Finally, the sample [`docker-compose.yml`](https://github.com/apache/druid/blob/ Once this is completed, open a PR to the master branch. Also, be sure to confirm that these versions are all correct in the release branch, otherwise fix them and open a backport PR to the release branch. +#### Version updates on master and release branch + +You also need to update the version manually in some places for both master branch and the release branch. +- `DRUID_DOCS_VERSION` has to be changed to `0.17.0` in `web-console/src/links.ts`. +- Docker image tag has to be changed to `0.17.0` for all druid services in `distribution/docker/docker-compose.yml`. Review Comment: this part about updating docker-compose.yml is already mentioned https://github.com/apache/druid/blob/master/distribution/asf-release-process-guide.md?plain=1#L62 ########## distribution/asf-release-process-guide.md: ########## @@ -248,10 +259,16 @@ must be tagged properly to make this script working. See the above [Release note Once the release branch is good for an RC, you can build a new tag with: ```bash -$ mvn -DreleaseVersion=0.17.0 -DdevelopmentVersion=0.18.0-SNAPSHOT -Dtag=druid-0.17.0-rc3 -DpushChanges=false clean release:clean release:prepare +$ mvn -Pwebsite-docs -DreleaseVersion=0.17.0 -DdevelopmentVersion=0.18.0-SNAPSHOT -Dtag=druid-0.17.0-rc3 -DpushChanges=false clean release:clean release:prepare Review Comment: does this do the right thing? The website-docs profile only has the website module, so will it only bump website version or is it additive? ########## distribution/asf-release-process-guide.md: ########## @@ -71,6 +71,17 @@ Finally, the sample [`docker-compose.yml`](https://github.com/apache/druid/blob/ Once this is completed, open a PR to the master branch. Also, be sure to confirm that these versions are all correct in the release branch, otherwise fix them and open a backport PR to the release branch. +#### Version updates on master and release branch Review Comment: I think these can all be done in the master branch and be part of the previous section, maybe instead add a bit that if any of these steps is missed, then update it in master and backport to the release branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
