gianm commented on code in PR #12634:
URL: https://github.com/apache/druid/pull/12634#discussion_r896244700
##########
processing/src/main/java/org/apache/druid/query/groupby/GroupByQuery.java:
##########
@@ -313,9 +319,9 @@ public LimitSpec getLimitSpec()
return limitSpec;
}
- @JsonInclude(JsonInclude.Include.NON_NULL)
- @JsonProperty("subtotalsSpec")
@Nullable
+ @JsonProperty("subtotalsSpec")
+ @JsonInclude(JsonInclude.Include.NON_EMPTY)
Review Comment:
IIRC empty `subtotalsSpec` is treated differently from null `subtotalsSpec`.
If that's accurate then this should be `NON_NULL`.
##########
processing/src/main/java/org/apache/druid/query/filter/SelectorDimFilter.java:
##########
@@ -118,21 +119,23 @@ public String getDimension()
@Nullable
@JsonProperty
+ @JsonInclude(JsonInclude.Include.NON_NULL)
Review Comment:
IMO, it would be better to omit the `@JsonInclude` here. `value` is a
required parameter for the selector filter, and `value: null` represents an "is
null" filter. It's weird for the canonical JSON form of an "is null" filter to
not have any `value` at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
