capistrant commented on PR #12599:
URL: https://github.com/apache/druid/pull/12599#issuecomment-1156418937

   > As to the main change: what do you think of calling the new column 
`last_updated`? IMO, that's clearer, since `last_used` sounds like it might be 
the last time the segment was loaded or queried or something like that.
   > 
   > Generally, this change would be very welcome. Measuring time-to-kill from 
the last update time makes more sense than measuring it from the data interval.
   
   I'm certainly open to different naming. `last_changed` spooks me because 
there could be a future where we change a row for some other reason than 
flipping the `used` flag. Perhaps `used_last_updated`, `[marked-]unused_since` 
(although this one might require us to re-think what the timestamp is when 
`used==true`. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to