imply-cheddar commented on code in PR #12646:
URL: https://github.com/apache/druid/pull/12646#discussion_r899685702
##########
pom.xml:
##########
@@ -1500,8 +1500,9 @@
<!-- set default options -->
<argLine>
@{jacocoArgLine}
+ ${jdk.surefire.argLine}
-Xmx1500m
- -XX:MaxDirectMemorySize=512m
+ -XX:MaxDirectMemorySize=2500m
Review Comment:
Because one of the configs that I removed had it set to that value and,
well, this setting is meaningless anyway (it has absolutely no functional
impact on the process, all it does it set a threshold for when exceptions get
thrown)
##########
pom.xml:
##########
@@ -1500,8 +1500,9 @@
<!-- set default options -->
<argLine>
@{jacocoArgLine}
+ ${jdk.surefire.argLine}
-Xmx1500m
- -XX:MaxDirectMemorySize=512m
+ -XX:MaxDirectMemorySize=2500m
Review Comment:
Because one of the configs that I removed on a child pom had it set to that
value and, well, this setting is meaningless anyway (it has absolutely no
functional impact on the process, all it does it set a threshold for when
exceptions get thrown)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
