imply-cheddar commented on code in PR #12646: URL: https://github.com/apache/druid/pull/12646#discussion_r899698434
########## processing/src/main/java/org/apache/druid/segment/QueryableIndex.java: ########## @@ -35,7 +38,7 @@ * @see QueryableIndexStorageAdapter for query path adapter * @see QueryableIndexIndexableAdapter for indexing path adapter */ -public interface QueryableIndex extends ColumnSelector, Closeable +public interface QueryableIndex extends Closeable Review Comment: It was not considered. It might work and might not. I don't remember places that were creating a cache just to throw it away, IIRC, they were all created in places that could actually have resources that need cleanup, so I think it's fine as is. If not, I'd put that cleanup in scope for another PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
