imply-cheddar commented on PR #12465: URL: https://github.com/apache/druid/pull/12465#issuecomment-1158793347
Doing just the interval interning would make this mergeable, definitely do a separate PR for the caching as the correctness of that is less clear. We should probably include the flamegraphs that led us to make this code change in this PR. In terms of memory consumption, the fields being stored on SegmentId are the exact same as what an Interval stores, by interning and reusing the same reference, given that the same interval tends to show up a lot, we should actually save on memory consumption versus increase it while also improving performance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
