kfaraz commented on PR #12671: URL: https://github.com/apache/druid/pull/12671#issuecomment-1161318819
The updated test seems to be passing (there is an unrelated failure). But upon taking another look at the method under test, `HttpEntity.openInputStream()`, I don't think the updated test adds much value. The `openInputStream()` method reads the content-range header which makes sense only for an HTTP URL connection, and not a file URI. Also, since the resource file does not actually exist, this is a trivial verification (no content == no content) rather than a verification of the stream skipping content. Even though I had suggested using a file uri earlier in #12668 , I guess it is not the best approach to fix this test after all. What do you think @cryptoe? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
