gianm opened a new pull request, #12693: URL: https://github.com/apache/druid/pull/12693
In PR #12187 the default was changed to `druid.coordinator.kill.on = true`. However, I think this is too risky of a default without the logic in #12526. Currently the main safeguard against accidental permanent deletion is `durationToRetain`, which is based on the segment interval, not the time the segment was marked unused. This means older segments can be eligible for autokilling immediately after being marked unused. This can happen by mistake: someone might activate the "mark unused" functionality (via API or web console) for the wrong datasource, or the wrong interval. Then autokilling can turn that small mistake into a big mistake. So, I think we should change the default back to `false` and revisit once the logic in #12526 is implemented. This patch does that, as well as updates the docs to be more clear about how the behavior works, so people can understand it prior to turning autokilling on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
