paul-rogers opened a new pull request, #12708: URL: https://github.com/apache/druid/pull/12708
This is a breakout from PR #12636: Single Pass through the Calcite planner. This PR adds just one item: a clone of the Calcite planner, lightly converted to Druid's coding style, with a method to provide access to the validator. The only tricky bit is the validator itself. While #12636 cloned the validator, this PR uses a sneaky approach: it defines `DruidSqlValidator` as a subclass of the unreachable `CalciteSqlValidator`. To do that, it lives in the same Calcite name space as `CalciteSqlValidator`. Some checkstyle hacking was needed to allow this odd state of affairs. There is zero change in functionality: everything works exactly as before. The goal here is simply to review the replacement of the Druid home-grown validator with the Calcite-provided one. This will then allow, in a later PR, to combine the validation and plan steps in the Druid planner. Testing is handled by the large number of existing SQL tests, including integration tests. <hr> This PR has: - [X] been self-reviewed. - [X] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [X] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
