clintropolis commented on code in PR #12714:
URL: https://github.com/apache/druid/pull/12714#discussion_r910675775
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidRexExecutor.java:
##########
@@ -172,7 +172,8 @@ public void reduce(
// complex constant is not reducible, so just leave it as an
expression
literal = constExp;
} else {
- if (exprResult.isArray()) {
+ if (!exprResult.type().isPrimitive()) {
+ // just leave complex expresions alone
// just leave array expressions on multi-value strings alone,
we're going to push them down into a virtual
// column selector anyway
Review Comment:
actually this adjustment was strange, immediately above this block there was
some stuff to already do the same thing for complex types, but it was a bit too
restrictive, so i've just changed it so that complex types are all handled in
that block instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
