clintropolis commented on code in PR #12727:
URL: https://github.com/apache/druid/pull/12727#discussion_r911629886


##########
integration-tests/src/test/java/org/apache/druid/tests/query/ITBroadcastJoinQueryTest.java:
##########
@@ -127,9 +130,22 @@ public void testBroadcastJoin() throws Exception
           
replaceJoinTemplate(getResourceAsString(BROADCAST_JOIN_QUERIES_RESOURCE), 
BROADCAST_JOIN_DATASOURCE)
       );
     }
+
     finally {
       closer.close();
 
+      coordinator.unloadSegmentsForDataSource(BROADCAST_JOIN_DATASOURCE);

Review Comment:
   ah yeah, i forgot to look closer at what unloader was doing, i just added 
these changes initially when i was thrashing around trying to find why stuff 
was failing and on the surface didn't seem to be quite the same, but see now 
that this is repeating a subset of what unloader was doing, so have removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to