maytasm commented on PR #12698: URL: https://github.com/apache/druid/pull/12698#issuecomment-1179274531
@a2l007 I am planning to close this PR. I found out that the region parameter is not really needed. If the user wants to ingestion data from s3 with different region than the region configured on the cluster (in runtime property), the user can set druid.s3.forceGlobalBucketAccessEnabled=true Unless you think there is any benefit of setting optional region parameter in each ingestionSpec rather than druid.s3.forceGlobalBucketAccessEnabled=true, I will go ahead and close this PR. The other component of this PR is endpoint url, and endpoint signing region which can be done in https://github.com/apache/druid/pull/11798 I think you can rebase https://github.com/apache/druid/pull/11798 and combine tests / docs as needed from this PR. I can review https://github.com/apache/druid/pull/11798 once it is ready. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
