vtlim commented on code in PR #12768:
URL: https://github.com/apache/druid/pull/12768#discussion_r919391759
##########
docs/querying/granularities.md:
##########
@@ -38,10 +38,27 @@ You can specify a time period as a
[simple](#simple-granularities) string, as a
Simple granularities are specified as a string and bucket timestamps by their
UTC time (e.g., days start at 00:00 UTC).
-Supported granularity strings are: `all`, `none`, `second`, `minute`,
`fifteen_minute`, `thirty_minute`, `hour`, `day`, `week`, `month`, `quarter`
and `year`.
-
-* `all` buckets everything into a single bucket
-* `none` does not bucket data (it actually uses the granularity of the index -
minimum here is `none` which means millisecond granularity). Using `none` in a
[TimeseriesQuery](../querying/timeseriesquery.md) is currently not recommended
(the system will try to generate 0 values for all milliseconds that didn’t
exist, which is often a lot).
+Supported granularity strings are:
+ - `all`
+ - `none`
+ - `second`
+ - `minute`
+ - `five_minute`
+ - `ten_minute`
+ - `fifteen_minute`
+ - `thirty_minute`
+ - `hour`
+ - `six_hour`
+ - `eight_hour`
+ - `day`
+ - `week`
+ - `month`
+ - `quarter`
+ - `year`
+
+> NOTE
+> * `all` buckets everything into a single bucket
+> * `none` does not bucket data (it actually uses the granularity of the index
- minimum here is `none` which means millisecond granularity). Using `none` in
a [TimeseriesQuery](../querying/timeseriesquery.md) is currently not
recommended (the system will try to generate 0 values for all milliseconds that
didn’t exist, which is often a lot).
Review Comment:
```suggestion
The minimum and maximum granularities are `none` and `all`, described as
follows:
* `all` buckets everything into a single bucket.
* `none` does not mean zero bucketing. It buckets data to millisecond
granularity—the granularity of the internal index. You can think of `none` as
equivalent to `millisecond`.
> Do not use `none` in a [timeseries
query](../querying/timeseriesquery.md); Druid fills empty interior time buckets
with zeroes, meaning the output will contain results for every single
millisecond in the requested interval.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
