maytasm commented on code in PR #12071: URL: https://github.com/apache/druid/pull/12071#discussion_r923926007
########## docs/design/coordinator.md: ########## @@ -113,7 +113,7 @@ need compaction. A set of segments needs compaction if all conditions below are satisfied: 1) Total size of segments in the time chunk is smaller than or equal to the configured `inputSegmentSizeBytes`. -2) Segments have never been compacted yet or compaction spec has been updated since the last compaction, especially `maxRowsPerSegment`, `maxTotalRows`, and `indexSpec`. +2) Segments have never been compacted yet or compaction spec has been updated since the last compaction: `maxTotalRows` or `indexSpec`. Review Comment: I know this isn't part of the change but we have added a bunch of other specs to auto compaction that if changed, will trigger compaction (i.e. dimensionSpec, metricsSpec, etc.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
