paul-rogers commented on PR #12844:
URL: https://github.com/apache/druid/pull/12844#issuecomment-1201903841
Thanks for the fix! The eternity intervals have other issues. They are very
cumbersome when comparing native queries, such as in tests. They require users
to know how to define such intervals when all that is wanted is "all data."
I wonder, should we define an additional "intervals" subclass? The existing
one for defined intervals, and a new one for the "all data" (i.e. "eternity")
case? Then, a native query might look like:
```json
"intervals" : {
"type" : "eternity"
},
```
Instead of:
```json
"intervals" : {
"type" : "intervals",
"intervals" : [
"-146136543-09-08T08:23:32.096Z/146140482-04-24T15:36:27.903Z" ]
},
```
With this, we express the intent, not the implementation.
Comparisons can then treat the "eternity" form special: eternity overlaps
with all other intervals by definition. There can never be multiple intervals
if there is eternity since, by definition, there is no additional period of
time beyond eternity.
This might be more of a change than we want to take on in this PR, but it is
a solution that would make life simpler in several ways.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
