wiquan commented on code in PR #12100:
URL: https://github.com/apache/druid/pull/12100#discussion_r935071316
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/hrtr/HttpRemoteTaskRunner.java:
##########
@@ -583,7 +583,7 @@ private void addWorker(final Worker worker)
for (Map.Entry<String, HttpRemoteTaskRunnerWorkItem> e :
tasks.entrySet()) {
if (e.getValue().getState() ==
HttpRemoteTaskRunnerWorkItem.State.RUNNING) {
Worker w = e.getValue().getWorker();
- if (w != null && w.getHost().equals(worker.getHost())) {
+ if (w != null && w.getHost().equals(worker.getHost()) &&
e.getValue().getTask() != null) {
Review Comment:
I see no risk in what was added, and your comment just delays the fix
getting into the upstream. There is no mention or requirement for IntelliJ
coding standards/annotations or whatever. If that bothers you that its not
ideal in your IDE, why don't you raise a PR for IntelliJ (<your IDE here>)
annotations and cleanups. Most likely the OP has already fixed in his fork and
made this PR for upstream and the rest of us. Now we have a stale PR (a valid
fix) for something others need. Please get real, there are over 1300 open
issues. Momentum would be nice, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
