abhishekagarwal87 commented on code in PR #12100:
URL: https://github.com/apache/druid/pull/12100#discussion_r936462015
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/hrtr/HttpRemoteTaskRunner.java:
##########
@@ -583,7 +583,7 @@ private void addWorker(final Worker worker)
for (Map.Entry<String, HttpRemoteTaskRunnerWorkItem> e :
tasks.entrySet()) {
if (e.getValue().getState() ==
HttpRemoteTaskRunnerWorkItem.State.RUNNING) {
Worker w = e.getValue().getWorker();
- if (w != null && w.getHost().equals(worker.getHost())) {
+ if (w != null && w.getHost().equals(worker.getHost()) &&
e.getValue().getTask() != null) {
Review Comment:
PR Authors can always agree or disagree with the code review. A UT was also
requested that has not been added yet. While we want to fix the open issues, we
do not want to compromise on the code quality.
Also, IntelliJ inspections is a test job that we run for each PR. Suneet is
referring to the inspections that run in the test job, not a local IDE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
