paul-rogers commented on code in PR #12816:
URL: https://github.com/apache/druid/pull/12816#discussion_r936881642
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/HadoopTask.java:
##########
@@ -48,13 +49,11 @@
public abstract class HadoopTask extends AbstractBatchIndexTask
{
private static final Logger log = new Logger(HadoopTask.class);
- private static final ExtensionsConfig EXTENSIONS_CONFIG;
-
- static final Injector INJECTOR = GuiceInjectors.makeStartupInjector();
- static {
- EXTENSIONS_CONFIG = INJECTOR.getInstance(ExtensionsConfig.class);
- }
+ // Note: static variables mean that this task cannot run in a shared JVM,
Review Comment:
Looking more closely, you may be right that this particular use is OK. There
will be a single injector and set of extensions used by multiple tasks, which
_should_ be OK. Removed the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
