gianm commented on code in PR #12848:
URL: https://github.com/apache/druid/pull/12848#discussion_r937080886
##########
processing/src/test/java/org/apache/druid/frame/write/FrameWritersTest.java:
##########
@@ -132,30 +132,27 @@ public void test_columnar_unsupportedColumnType()
@Test
public void test_rowBased_unsupportedSortColumnType()
{
+ // Register, but don't unregister, because many other tests out there
expect this to exist even though they
Review Comment:
It's the opposite: doing the unregister caused flakiness. We have a bunch of
tests that expect HyperUniquesSerde to be registered, even though they don't
explicitly register it. So new tests shouldn't unregister it unless all
existing unit tests are updated to explicitly register it when they need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
