cryptoe commented on PR #12862:
URL: https://github.com/apache/druid/pull/12862#issuecomment-1206343386
Thanks for the review @abhishekagarwal87 @LakshSingla .
> 1. Are implementations of AggregatorFactory stateless? In those cases,
is there an advantage of just changing the `name` inside the aggregator factory
instead of returning a new aggregator factory? It also depends on the usage and
how often we intend to call the function, so if the call won't be frequent it
won't matter much.
Yes the calls are not that frequent so It won't matter much.
> 2. Can there be any test case for the change?
Added some UT's .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
