clintropolis commented on code in PR #12855:
URL: https://github.com/apache/druid/pull/12855#discussion_r940889697
##########
processing/src/main/java/org/apache/druid/query/groupby/GroupByQueryQueryToolChest.java:
##########
@@ -556,9 +564,37 @@ public byte[] computeResultLevelCacheKey(GroupByQuery
query)
builder.appendStrings(subTotalSpec);
}
}
+ if (query.getLimitSpec() instanceof DefaultLimitSpec) {
Review Comment:
dimension names are stored in their cache key, but aggs are not
(consistently at least, though some are). Yeah, that would resolve the result
level cache issue, though it is a shame that cosmetic stuff could reduce the
cache hit rate when all that _really_ matters is that everything is in the same
place and ordered/limited the same.
I wonder if instead of anything using name we should rework this sometime in
the future to use position or something...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
