rohangarg opened a new pull request, #12894:
URL: https://github.com/apache/druid/pull/12894
As a part of the fix in #11517, the case where if a join is fully converted
into filter is missing.
If the join fully converts to a non-null filter, we should convey that the
storage adapter might have built-in filters.
It might be the case that the outer query doesn't have any filters, so to
inform the topN query engine that the scan is not on the full segment, we need
to convey it via the join's storage adapter. This will help the topN query
engine in taking decision whether to short circuit the scan or not.
This was uncovered when the existing test for
`CalciteQueryTest#testExactTopNOnInnerJoinWithLimit` started failing as a part
of #12868
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [x] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
