gianm commented on code in PR #12897:
URL: https://github.com/apache/druid/pull/12897#discussion_r944774524
##########
sql/src/main/java/org/apache/druid/sql/calcite/run/EngineFeature.java:
##########
@@ -20,12 +20,18 @@
package org.apache.druid.sql.calcite.run;
import org.apache.druid.sql.calcite.external.ExternalDataSource;
+import org.apache.druid.sql.calcite.planner.PlannerContext;
/**
- * Arguments to {@link QueryFeatureInspector#feature(QueryFeature)}.
+ * Arguments to {@link EngineFeatureInspector#feature(EngineFeature,
PlannerContext)}.
*/
-public enum QueryFeature
+public enum EngineFeature
{
+ /**
+ * Can execute INSERT and REPLACE statements.
+ */
+ CAN_INSERT,
Review Comment:
This one is shorter? 🙂
I could go either way on this one to be honest. I don't have a super strong
argument for one vs. the other. For that reason I'm inclined to leave it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
