kfaraz commented on code in PR #12875:
URL: https://github.com/apache/druid/pull/12875#discussion_r945045038
##########
indexing-service/src/test/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisorStateTest.java:
##########
@@ -1326,6 +1339,9 @@ protected Map<String, Long> getPartitionTimeLag()
@Override
protected void emitLag()
{
+ if ((metricFlag & LAG) == 0) {
Review Comment:
This is a nice approach but we would only be able to track 8 metrics at
most. Wouldn't it be simpler to just do `metricFlag != LAG`?
##########
integration-tests/src/test/java/org/apache/druid/tests/security/ITTLSTest.java:
##########
@@ -537,4 +534,19 @@ private StatusResponseHolder makeRequest(
throw new RuntimeException(e);
}
}
+
+ private boolean isRetriable(Throwable ex)
Review Comment:
`isRetriable` seems a little off 😅. Maybe use `canRetry` or `shouldRetry`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
