rohangarg commented on code in PR #12901:
URL: https://github.com/apache/druid/pull/12901#discussion_r945334933
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java:
##########
@@ -82,14 +84,21 @@
*/
public class TaskQueue
{
- private final long MANAGEMENT_WAIT_TIMEOUT_NANOS =
TimeUnit.SECONDS.toNanos(60);
- private final long MIN_WAIT_TIME_MS = 100;
+ private static final long MANAGEMENT_WAIT_TIMEOUT_NANOS =
TimeUnit.SECONDS.toNanos(60);
+ private static final long MIN_WAIT_TIME_MS = 100;
+ // Task ID -> Task that is currently running
Review Comment:
I think this map can contain tasks in pending state too. Also, this could be
out-of-sync with task-storage as per documentation (upon manual changes in
task-storage). Maybe, this can be called in-memory view of known tasks?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
