panhongan commented on PR #11296: URL: https://github.com/apache/druid/pull/11296#issuecomment-1215101306
@kfaraz Thanks very much for your review and comments. Good suggestion for me. I have simplified `SeekableStreamIndexTaskClient`. And help review again. @AmatyaAvadhanula Thanks for your review, too. Yes, for better task status control, I make change for `SeekableStreamIndexTaskRunner#pause()`. The bad case is: in current `checkTaskDuration()` round, the task pause timeout, but for next `checkTaskDuration()` round, the task has become `PUBLISHING`. I think the supervisor should accept the fact that the task is running ok, not to throw exception: `Can't pause, task state is invalid (state: [PUBLISHING])`. @kfaraz @AmatyaAvadhanula You can help review this point. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
