paul-rogers opened a new pull request, #12909: URL: https://github.com/apache/druid/pull/12909
PR #12845 converted `SqlLifecycle` into a set of statement classes. The `DirectStatement` class combined planning and execution into a single `execute()` method. However, it turns out that a consumer outside of the Druid code base had need to separate the plan portion of the operation from execution. This PR provides that separation in the form of a `ResultSet` class that holds onto the "physical plan" (such as it is in Druid) and does the execution step. The previous `execute()` method still exists for the code, within Druid, that uses the all-in-one approach. <hr> This PR has: - [X] been self-reviewed. - [X] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [X] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
