FrankChen021 commented on PR #12915: URL: https://github.com/apache/druid/pull/12915#issuecomment-1218920133
`toMap` is a public interface that could be used anywhere, seems that all callers have to use the same way as `EventToJsonSerializer` to serialize the map object. I don't know if there's any better idea that callers should not care about handling the serialization in a special way. Another point is this test case `DefaultRequestLogEventTest#testDefaultrequestLogEventSerde` should cover the serialization of `toMap` method. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
