AlexanderSaydakov commented on code in PR #12498:
URL: https://github.com/apache/druid/pull/12498#discussion_r949522394


##########
docs/development/extensions-core/datasketches-quantiles.md:
##########
@@ -56,7 +56,7 @@ The result of the aggregation is a DoublesSketch that is the 
union of all sketch
 |name|A String for the output (result) name of the calculation.|yes|
 |fieldName|A String for the name of the input field (can contain sketches or 
raw numeric values).|yes|
 |k|Parameter that determines the accuracy and size of the sketch. Higher k 
means higher accuracy but more space to store sketches. Must be a power of 2 
from 2 to 32768. See [accuracy 
information](https://datasketches.apache.org/docs/Quantiles/OrigQuantilesSketch)
 in the DataSketches documentation for details.|no, defaults to 128|
-|maxStreamLength|This parameter is a temporary solution to avoid a [known 
issue](https://github.com/apache/druid/issues/11544). It may be removed in a 
future release after the bug is fixed. This parameter defines the maximum 
number of items to store in each sketch. If a sketch reaches the limit, the 
query can throw `IllegalStateException`. To workaround this issue, increase the 
maximum stream length. See [accuracy 
information](https://datasketches.apache.org/docs/Quantiles/OrigQuantilesSketch)
 in the DataSketches documentation for how many bytes are required per stream 
length.|no, defaults to 1000000000|

Review Comment:
   Yes, the parameter was introduced to temporarily work around a bug, but 
after some discussion it was decided that it might be useful regardless



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to